Open
Conversation
|
I see how you abstracted the strings, but I don't see how translated text are provided. If you create tests, please add that part too |
Author
|
Here is the part that lets you provide translations, it's exported from the package The usage is pretty simple: import { setTranslations } from 'html5-qrcode';
const myOwnTranslationObject = {
"common": {
"cameraStreamingNotSupported": "Потоковое воспроизведение камеры не поддерживается браузером.",
"unableToQuerySupportedDevices": "Невозможно запросить поддерживаемые устройства, неизвестная ошибка."
},
...
}
setTranslations(myOwnTranslationObject);Also it's easy to use with translation libraries, for i18next it would be so: import { t } from 'i18next';
import { setTranslations } from 'html5-qrcode';
setTranslations(t('html5QrCode', { returnObjects: true })); |
mokalovesoulmate
added a commit
to mokalovesoulmate/html5-qrcode
that referenced
this pull request
May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi colleagues!
I suggest the following solution:
"scanner.scanningStatus"resembling i18next library.setTranslationsfunction exported from the package.I guess the main pros of this approach is that it's not needed to make translations to many languages and then support them all. Those who really need it may set their own translations as they like.
If the solution is fine, I'll write unit tests and other stuff I might've missed.